MODEUR-175 Avoid multiplication of usage counts#200
Merged
Conversation
... when there are multiple invoices for a subscription. Changes: - add aggregated view of costs per agreement line and join usage data with that instead of with agreement_entries; to avoid that usage counts are multiplied by the number of invoices - fix the unit test sample data setup that would set the same cost on every agreement line for an agreement id, as opposed to the application itself that will instead insert a new unique agreement line for every invoice/cost into agreement_entries - use this to change the sample data to apply multiple invoices with different costs for a line, in order to properly test that request counts and costs are properly summed up and divided for cost per request
|
adamdickmeiss
approved these changes
Mar 18, 2026
| return; | ||
| } | ||
| UUID poLineId = UUID.fromString(query.substring(10)); | ||
| UUID poLineId = UUID.fromString(query.substring(10,46)); |
Contributor
Author
There was a problem hiding this comment.
Well, for https://folio-org.atlassian.net/browse/MODEUR-176 actually, query will get an additional parameter. PR coming soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... when there are multiple invoices for a subscription.
Changes: